Browse files

Figured out how to get the final task to work properly

  • Loading branch information...
1 parent 7125544 commit 30a4a49421ab930bd392f0d691aaa178d7f47989 @mrmark mrmark committed with mudrd8mz Mar 17, 2011
Showing with 7 additions and 10 deletions.
  1. +1 −10 backup/converter/moodle1/converter.class.php
  2. +6 −0 backup/moodle2/convert_stepslib.php
View
11 backup/converter/moodle1/converter.class.php
@@ -39,15 +39,6 @@ public function build_plan() {
$this->get_plan()->add_task(new moodle1_root_task('root_task'));
$this->get_plan()->add_task(new moodle1_course_task('courseinfo'));
- // $this->get_plan()->add_task(new moodle1_final_task('final_task')); // @todo OK, cannot do this here because things get processed after we parse xml...
+ $this->get_plan()->add_task(new moodle1_final_task('final_task'));
}
-
- public function destroy() {
- parent::destroy();
-
- // @todo Doing this here for now instead of via a task/step
- backup_controller_dbops::drop_backup_ids_temp_table($this->get_id()); // Drop ids temp table
- }
-
-
}
View
6 backup/moodle2/convert_stepslib.php
@@ -15,6 +15,12 @@ protected function define_execution() {
class convert_drop_and_clean_temp_stuff extends convert_execution_step {
protected function define_execution() {
+ // We want to run after execution
+ }
+
+ public function execute_after_convert() {
backup_controller_dbops::drop_backup_ids_temp_table($this->get_convertid()); // Drop ids temp table
}
+
+
}

0 comments on commit 30a4a49

Please sign in to comment.