Permalink
Browse files

MDL-43306 restore: fix grade item sortorder restoration

Previously, restore was blindly inserting the old sort order into the
database, causing duplicate sortorders which lead to unpredicatble
sorting results.

Now we will use the api function to add it after the original sortorder,
this means if a duplicate exists in the original location, this item
will appear after it.
  • Loading branch information...
danpoltawski committed Dec 10, 2013
1 parent cf0e970 commit 32df282b1bede6c21e5385b34201c53906542604
Showing with 3 additions and 3 deletions.
  1. +3 −3 backup/moodle2/restore_stepslib.php
@@ -2769,9 +2769,9 @@ protected function process_grade_item($data) {
$gradeitem = new grade_item($data, false);
$gradeitem->insert('restore');
//sortorder is automatically assigned when inserting. Re-instate the previous sortorder
$gradeitem->sortorder = $data->sortorder;
$gradeitem->update('restore');
// Reinstate the grade item close to its original sortorder, if something already exists
// in the original sortorer then it will be first.
$gradeitem->move_after_sortorder($data->sortorder);
// Set mapping, saving the original category id into parentitemid
// gradebook restore (final task) will need it to reorganise items

0 comments on commit 32df282

Please sign in to comment.