Permalink
Browse files

MDL-33588 Ensure that a drop target is defined before checking a drop…

… group
  • Loading branch information...
1 parent a2d1d76 commit 371409f41e7b0f30f953f976f0bb65f1f6128939 @andrewnicols andrewnicols committed Jun 7, 2012
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/yui/dragdrop/dragdrop.js
@@ -135,7 +135,7 @@ YUI.add('moodle-core-dragdrop', function(Y) {
global_drop_over : function(e) {
// Check that drop object belong to correct group
- if (!e.drop.inGroup(this.groups)) {
+ if (!e.drop || !e.drop.inGroup(this.groups)) {
return;
}
//Get a reference to our drag and drop nodes
@@ -168,7 +168,7 @@ YUI.add('moodle-core-dragdrop', function(Y) {
// this.lastdroptarget (ghost node we use for indicating where to drop)
e.drag = e.target;
// Check that drop object belong to correct group
- if (!e.drag.target.inGroup(this.groups)) {
+ if (!e.drop || !e.drop.inGroup(this.groups)) {
return;
}
e.drop = this.lastdroptarget;
@@ -177,7 +177,7 @@ YUI.add('moodle-core-dragdrop', function(Y) {
global_drop_hit : function(e) {
// Check that drop object belong to correct group
- if (!e.drop.inGroup(this.groups)) {
+ if (!e.drop || !e.drop.inGroup(this.groups)) {
return;
}
this.drop_hit(e);

0 comments on commit 371409f

Please sign in to comment.