Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-29325 Enrol : reduced isset calls and improved readability

  • Loading branch information...
commit 3b89933d9f72f5fcededed6c26010c321c1fa52c 1 parent 903ab24
@nebgor nebgor authored
Showing with 5 additions and 3 deletions.
  1. +5 −3 enrol/imsenterprise/lib.php
View
8 enrol/imsenterprise/lib.php
@@ -359,14 +359,16 @@ function process_group_tag($tagcontents) {
$this->log_line("Course $coursecode not found in Moodle's course idnumbers.");
} else {
// Set shortname to description or description to shortname if one is set but not the other.
- if (!isset($group->description) && !isset($group->shortName)) {
+ $nodescription = !isset($group->description);
+ $noshortname = !isset($group->shortname);
+ if ( $nodescription && $noshortname) {
// If neither short nor long description are set let if fail
$this->log_line("Neither long nor short name are set for $coursecode");
- } else if (!isset($group->description)) {
+ } else if ($nodescription) {
// If short and ID exist, then give the long short's value, then give short the ID's value
$group->description = $group->shortName;
$group->shortName = $coursecode;
- } else if (!isset($group->shortName)) {
+ } else if ($noshortname) {
// If long and ID exist, then map long to long, then give short the ID's value.
$group->shortName = $coursecode;
}
Please sign in to comment.
Something went wrong with that request. Please try again.