Permalink
Browse files

Merge branch 'MDL-30734_22' of git://github.com/timhunt/moodle into M…

…OODLE_22_STABLE
  • Loading branch information...
2 parents 265dbb3 + 9831354 commit 3bcb2c1dff99a0869b24e16bb35528c3a381d5e8 Sam Hemelryk committed Dec 18, 2011
Showing with 5 additions and 1 deletion.
  1. +5 −1 question/engine/datalib.php
@@ -851,7 +851,11 @@ public function set_max_mark_in_attempts(qubaid_condition $qubaids, $slot, $newm
* @return string SQL code for the subquery.
*/
public function sum_usage_marks_subquery($qubaid) {
- return "SELECT SUM(qa.maxmark * qas.fraction)
+ // To explain the COALESCE in the following SQL: SUM(lots of NULLs) gives
+ // NULL, while SUM(one 0.0 and lots of NULLS) gives 0.0. We don't want that.
+ // We always want to return a number, so the COALESCE is there to turn the
+ // NULL total into a 0.
+ return "SELECT COALESCE(SUM(qa.maxmark * qas.fraction), 0)
FROM {question_attempts} qa
JOIN {question_attempt_steps} qas ON qas.id = (
SELECT MAX(summarks_qas.id)

0 comments on commit 3bcb2c1

Please sign in to comment.