From 3dd8bd5069401abd48454b79feffa927da46df2b Mon Sep 17 00:00:00 2001 From: Andrew Davis Date: Mon, 4 Aug 2014 12:04:37 +0800 Subject: [PATCH] MDL-43740 core_grade: Thanks to Robert Russo for the patch. Removed the ability to set manual grade items to grade type "None" --- grade/edit/tree/item_form.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/grade/edit/tree/item_form.php b/grade/edit/tree/item_form.php index 67c7a208cf79a..b9dc0d234fab7 100644 --- a/grade/edit/tree/item_form.php +++ b/grade/edit/tree/item_form.php @@ -51,10 +51,10 @@ function definition() { $mform->addHelpButton('idnumber', 'idnumbermod'); $mform->setType('idnumber', PARAM_RAW); - $options = array(GRADE_TYPE_NONE=>get_string('typenone', 'grades'), - GRADE_TYPE_VALUE=>get_string('typevalue', 'grades'), - GRADE_TYPE_SCALE=>get_string('typescale', 'grades'), - GRADE_TYPE_TEXT=>get_string('typetext', 'grades')); + // Manual grade items cannot have grade type GRADE_TYPE_NONE. + $options = array(GRADE_TYPE_VALUE => get_string('typevalue', 'grades'), + GRADE_TYPE_SCALE => get_string('typescale', 'grades'), + GRADE_TYPE_TEXT => get_string('typetext', 'grades')); $mform->addElement('select', 'gradetype', get_string('gradetype', 'grades'), $options); $mform->addHelpButton('gradetype', 'gradetype', 'grades');