MDL-60241 course: General section always visible (topics, weeks)

moodle · Mar 9, 2018 · 3e316b8 · 3e316b8
1 parent e95f91c
commit 3e316b8
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/course/format/topics/db/upgrade.php b/course/format/topics/db/upgrade.php
@@ -46,5 +46,15 @@ function xmldb_format_topics_upgrade($oldversion) {
     // Automatically generated Moodle v3.3.0 release upgrade line.
     // Put any upgrade step following this.
 
+    if ($oldversion < 2017051501) {
+
+        // During upgrade to Moodle 3.3 it could happen that general section (section 0) became 'invisible'.
+        // It should always be visible.
+        $DB->execute("UPDATE {course_sections} SET visible=1 WHERE visible=0 AND section=0 AND course IN
+        (SELECT id FROM {course} WHERE format=?)", ['topics']);
+
+        upgrade_plugin_savepoint(true, 2017051501, 'format', 'topics');
+    }
+
     return true;
 }
diff --git a/course/format/topics/version.php b/course/format/topics/version.php
@@ -25,6 +25,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2017051500;        // The current plugin version (Date: YYYYMMDDXX).
+$plugin->version   = 2017051501;        // The current plugin version (Date: YYYYMMDDXX).
 $plugin->requires  = 2017050500;        // Requires this Moodle version.
 $plugin->component = 'format_topics';    // Full name of the plugin (used for diagnostics).
diff --git a/course/format/weeks/db/upgrade.php b/course/format/weeks/db/upgrade.php
@@ -82,5 +82,15 @@ function xmldb_format_weeks_upgrade($oldversion) {
     // Automatically generated Moodle v3.3.0 release upgrade line.
     // Put any upgrade step following this.
 
+    if ($oldversion < 2017051501) {
+
+        // During upgrade to Moodle 3.3 it could happen that general section (section 0) became 'invisible'.
+        // It should always be visible.
+        $DB->execute("UPDATE {course_sections} SET visible=1 WHERE visible=0 AND section=0 AND course IN
+        (SELECT id FROM {course} WHERE format=?)", ['weeks']);
+
+        upgrade_plugin_savepoint(true, 2017051501, 'format', 'weeks');
+    }
+
     return true;
 }
diff --git a/course/format/weeks/version.php b/course/format/weeks/version.php
@@ -25,6 +25,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2017051500;        // The current plugin version (Date: YYYYMMDDXX).
+$plugin->version   = 2017051501;        // The current plugin version (Date: YYYYMMDDXX).
 $plugin->requires  = 2017050500;        // Requires this Moodle version.
 $plugin->component = 'format_weeks';    // Full name of the plugin (used for diagnostics).