Permalink
Browse files

added PARAM types when calling "required_param" and "optional_param" …

…functions
  • Loading branch information...
1 parent 008537d commit 3fc2c3c26613207b3e2679efeeab02534673561c gbateson committed Sep 28, 2006
Showing with 63 additions and 60 deletions.
  1. +63 −60 mod/hotpot/show.php
View
@@ -1,68 +1,71 @@
<?php // $Id$
- require_once("../../config.php");
- require_once("lib.php");
- require_login();
- // fetch and clean the required $_GET parameters
- // (script stops here if any parameters are missing)
- unset($params);
- $params->action = required_param('action');
- $params->course = required_param('course');
- $params->reference = required_param('reference');
- require_login($params->course);
- if (!isteacher($params->course)) {
- error("You are not allowed to view this page!");
- }
- if (isadmin()) {
- $params->location = optional_param('location', HOTPOT_LOCATION_COURSEFILES);
- } else {
- $params->location = HOTPOT_LOCATION_COURSEFILES;
- }
- $title = get_string($params->action, 'hotpot').': '.$params->reference;
- print_header($title, $title);
- hotpot_print_show_links($params->course, $params->location, $params->reference);
+
+ require_once("../../config.php");
+ require_once("lib.php");
+
+ $params = new stdClass();
+ $params->action = required_param('action', PARAM_ALPHA);
+ $params->course = required_param('course', PARAM_INT);
+ $params->reference = required_param('reference', PARAM_PATH);
+
+ require_login($params->course);
+ if (!isteacher($params->course)) {
+ error("You are not allowed to view this page!");
+ }
+ if (isadmin()) {
+ $params->location = optional_param('location', HOTPOT_LOCATION_COURSEFILES, PARAM_INT);
+ } else {
+ $params->location = HOTPOT_LOCATION_COURSEFILES;
+ }
+
+ $title = get_string($params->action, 'hotpot').': '.$params->reference;
+ print_header($title, $title);
+ hotpot_print_show_links($params->course, $params->location, $params->reference);
?>
<script type="text/javascript" language="javascript">
<!--
- // http://www.krikkit.net/howto_javascript_copy_clipboard.html
- function copy_contents(id) {
- if (id==null) {
- id = 'contents';
- }
- var obj = null;
- if (document.getElementById) {
- obj = document.getElementById(id);
- }
- if (obj && window.clipboardData) {
- window.clipboardData.setData("Text", obj.innerText);
- alert('<?php print_string('copiedtoclipboard', 'hotpot') ?>');
- }
- }
- document.write('<span class="helplink"> &nbsp; <a href="javascript:copy_contents()"><?php print_string('copytoclipboard', 'hotpot') ?></A></span>');
+ // http://www.krikkit.net/howto_javascript_copy_clipboard.html
+ function copy_contents(id) {
+ if (id==null) {
+ id = 'contents';
+ }
+ var obj = null;
+ if (document.getElementById) {
+ obj = document.getElementById(id);
+ }
+ if (obj && window.clipboardData) {
+ window.clipboardData.setData("Text", obj.innerText);
+ alert('<?php print_string('copiedtoclipboard', 'hotpot') ?>');
+ }
+ }
+ document.write('<span class="helplink"> &nbsp; <a href="javascript:copy_contents()"><?php print_string('copytoclipboard', 'hotpot') ?></A></span>');
-->
</script>
<?php
- print_simple_box_start("center", "96%");
- if($hp = new hotpot_xml_quiz($params)) {
- print '<pre id="contents">';
- switch ($params->action) {
- case 'showxmlsource':
- print htmlspecialchars($hp->source);
- break;
- case 'showxmltree':
- print_r($hp->xml);
- break;
- case 'showhtmlsource':
- print htmlspecialchars($hp->html);
- break;
- case 'showhtmlquiz':
- print $hp->html;
- break;
- }
- print '</pre>';
- } else {
- print_simple_box("Could not open Hot Potatoes XML file", "center", "", "#FFBBBB");
- }
- print_simple_box_end();
- print '<br />';
- close_window_button();
+ print_simple_box_start("center", "96%");
+ if($hp = new hotpot_xml_quiz($params)) {
+ print '<pre id="contents">';
+ switch ($params->action) {
+ case 'showxmlsource':
+ print htmlspecialchars($hp->source);
+ break;
+ case 'showxmltree':
+ if (isset($hp->xml)) {
+ print_r($hp->xml);
+ }
+ break;
+ case 'showhtmlsource':
+ print htmlspecialchars($hp->html);
+ break;
+ case 'showhtmlquiz':
+ print $hp->html;
+ break;
+ }
+ print '</pre>';
+ } else {
+ print_simple_box("Could not open Hot Potatoes XML file", "center", "", "#FFBBBB");
+ }
+ print_simple_box_end();
+ print '<br />';
+ close_window_button();
?>

0 comments on commit 3fc2c3c

Please sign in to comment.