Skip to content
Browse files

MDL-32249 completion: Round course grades and remove hardcoded string

  • Loading branch information...
1 parent ead4f18 commit 412cecc32bd33b108008791090f420b6892b4cac @srynot4sale srynot4sale committed Apr 11, 2012
Showing with 8 additions and 7 deletions.
  1. +1 −0 lang/en/completion.php
  2. +7 −7 lib/completion/completion_criteria_grade.php
View
1 lang/en/completion.php
@@ -118,6 +118,7 @@
$string['daysafterenrolment']='Days after enrolment';
$string['durationafterenrolment']='Duration after enrolment';
$string['fraction']='Fraction';
+$string['gradetopass']='{$a} to pass';
$string['inprogress']='In progress';
$string['manualcompletionby']='Manual completion by';
$string['manualselfcompletion']='Manual self completion';
View
14 lib/completion/completion_criteria_grade.php
@@ -156,14 +156,14 @@ public function get_type_title() {
* @return string
*/
public function get_status($completion) {
- // Cast as floats to get rid of excess decimal places
- $grade = (float) $this->get_grade($completion);
- $gradepass = (float) $this->gradepass;
+ $grade = $this->get_grade($completion);
+ $gradepass = round($this->gradepass, 2).'%';
if ($grade) {
- return $grade.'% ('.$gradepass.'% to pass)';
+ $grade = round($grade, 2);
+ return $grade.'% ('.get_string('gradetopass', 'completion', $gradepass).')';
} else {
- return $gradepass.'% to pass';
+ return get_string('gradetopass', 'completion', $gradetopass);
}
}
@@ -232,10 +232,10 @@ public function get_details($completion) {
$details = array();
$details['type'] = get_string('coursegrade', 'completion');
$details['criteria'] = get_string('passinggrade', 'completion');
- $details['requirement'] = ((float)$this->gradepass).'%';
+ $details['requirement'] = round($this->gradepass, 2).'%';
$details['status'] = '';
- $grade = (float)$this->get_grade($completion);
+ $grade = round($this->get_grade($completion), 2);
if ($grade) {
$details['status'] = $grade.'%';
}

0 comments on commit 412cecc

Please sign in to comment.
Something went wrong with that request. Please try again.