From 9bf6815753b2a834c32eb7539f79f29c2c99848f Mon Sep 17 00:00:00 2001 From: Adam Olley Date: Fri, 18 Mar 2011 15:02:55 +0800 Subject: [PATCH 1/2] user-selector MDL-25975 Fixed timeout bug in user selector that was affecting IE8 --- user/selector/module.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user/selector/module.js b/user/selector/module.js index d53b5e027b154..e6818c88f7cc1 100644 --- a/user/selector/module.js +++ b/user/selector/module.js @@ -89,7 +89,7 @@ M.core_user.init_user_selector = function (Y, name, hash, extrafields, lastsearc handle_keyup : function(e) { // Trigger an ajax search after a delay. this.cancel_timeout(); - this.timeoutid = setTimeout(function(obj){obj.send_query(false)}, this.querydelay*1000, this); + this.timeoutid = Y.later(this.querydelay*1000, e, function(obj){obj.send_query(false)}, this); // Enable or diable the clear button. this.clearbutton.set('disabled', (this.get_search_text() == '')); From c78262b54269c5f5dfe22dc93145e78c4c87da9e Mon Sep 17 00:00:00 2001 From: Sam Hemelryk Date: Mon, 21 Mar 2011 10:22:28 +0800 Subject: [PATCH 2/2] navigation MDL-26903 Fixed regression to navigation ajax after CM changes --- lib/navigationlib.php | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/navigationlib.php b/lib/navigationlib.php index 5376bed4caeb9..722cf84a6179b 100644 --- a/lib/navigationlib.php +++ b/lib/navigationlib.php @@ -2247,23 +2247,22 @@ public function initialise() { $this->load_section_activities($sections[$course->sectionnumber]->sectionnode, $course->sectionnumber, get_fast_modinfo($course)); break; case self::TYPE_ACTIVITY : - $course = $DB->get_record('course', array('id'=>$cm->course), '*', MUST_EXIST); + $sql = "SELECT c.* + FROM {course} c + JOIN {course_modules} cm ON cm.course = c.id + WHERE cm.id = :cmid"; + $params = array('cmid' => $this->instanceid); + $course = $DB->get_record_sql($sql, $params, MUST_EXIST); $modinfo = get_fast_modinfo($course); $cm = $modinfo->get_cm($this->instanceid); require_course_login($course, true, $cm); $this->page->set_context(get_context_instance(CONTEXT_MODULE, $cm->id)); $coursenode = $this->load_course($course); - $sections = $this->load_course_sections($course, $coursenode); - foreach ($sections as $section) { - if ($section->id == $cm->section) { - $cm->sectionnumber = $section->section; - break; - } - } if ($course->id == SITEID) { $modulenode = $this->load_activity($cm, $course, $coursenode->find($cm->id, self::TYPE_ACTIVITY)); } else { - $activities = $this->load_section_activities($sections[$cm->sectionnumber]->sectionnode, $cm->sectionnumber, get_fast_modinfo($course)); + $sections = $this->load_course_sections($course, $coursenode); + $activities = $this->load_section_activities($sections[$cm->sectionnum]->sectionnode, $cm->sectionnum, get_fast_modinfo($course)); $modulenode = $this->load_activity($cm, $course, $activities[$cm->id]); } break;