Permalink
Browse files

MDL-30821 SCORM Fixing issues with SCORM report when there are no att…

…empts to report
  • Loading branch information...
1 parent 52e6baa commit 45462d20a20e1f5a4f84251074a5f3738ea38831 @ankitagarwal ankitagarwal committed Feb 7, 2012
Showing with 11 additions and 5 deletions.
  1. +11 −5 mod/scorm/report.php
View
@@ -528,12 +528,18 @@
echo '</tr></table>';
}
}
- if (!$download) {
- $mform->set_data($displayoptions + compact('detailedrep', 'pagesize'));
- $mform->display();
- }
} else {
- echo $OUTPUT->notification(get_string('noactivity', 'scorm'));
+ if ($candelete && !$download) {
+ echo '</div>';
+ echo '</form>';
+ $table->finish_output();
+ }
+ echo '</div>';
+ }
+ // Show preferences form irrespective of whether there are attempts to report or not
+ if (!$download) {
+ $mform->set_data($displayoptions + compact('detailedrep', 'pagesize', 'attemptsmode'));
+ $mform->display();
}
if ($download == 'Excel' or $download == 'ODS') {
$workbook->close();

0 comments on commit 45462d2

Please sign in to comment.