Permalink
Browse files

Remove long answer check - does not seem to be requires as db field i…

…s 'text'

Fixed notices caused by uninitialised $question variable
  • Loading branch information...
thepurpleblob
thepurpleblob committed Jul 20, 2005
1 parent 1c36cd2 commit 486ca471fb9aed77a25f7d27f7b9dc7d3a3bd5e6
Showing with 5 additions and 5 deletions.
  1. +5 −5 mod/quiz/format/webct/format.php
@@ -346,14 +346,10 @@ function readquestions ($lines) {
$QuestionOK = FALSE;
}
else {
- // Perform string length check and create empty feedback array
+ // Create empty feedback array
$question->feedback = array();
foreach ($question->answer as $key => $dataanswer) {
$question->feedback[$key] = '';
- if (strlen($dataanswer) > 255) {
- $question->answer[$key] = substr($dataanswer,0,250)."...";
- $warnings[] = get_string("answertoolong", "quiz", $nQuestionStartLine);
- }
}
$maxfraction = -1;
$totalfraction = 0;
@@ -501,6 +497,10 @@ function readquestions ($lines) {
}
// Need to put the parsing of calculated items here to avoid ambitiuosness:
+ // if question isn't defined yet there is nothing to do here (avoid notices)
+ if (!isset($question)) {
+ continue;
+ }
if (CALCULATED == $question->qtype && ereg(
"^:([[:lower:]].*|::.*)-(MIN|MAX|DEC|VAL([0-9]+))::?:?($webctnumberregex)", $line, $webct_options)) {
$datasetname = ereg_replace('^::', '', $webct_options[1]);

0 comments on commit 486ca47

Please sign in to comment.