Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

MDL-31775 Lesson Module: fixed start at last page seen bug

  • Loading branch information...
commit 49ef5d4c7f95ed1d58e7b03b19979f1309887581 1 parent a2b30aa
@rwijaya rwijaya authored
Showing with 11 additions and 13 deletions.
  1. +11 −13 mod/lesson/view.php
View
24 mod/lesson/view.php
@@ -194,20 +194,18 @@
// if there are any questions have been answered correctly in this attempt
$corrrectattempts = $lesson->get_attempts($retries, true);
if ($corrrectattempts>0) {
- foreach ($corrrectattempts as $attempt) {
- $jumpto = $DB->get_field('lesson_answers', 'jumpto', array('id' => $attempt->answerid));
- // convert the jumpto to a proper page id
- if ($jumpto == 0) { // unlikely value!
- $lastpageseen = $attempt->pageid;
- } elseif ($jumpto == LESSON_NEXTPAGE) {
- if (!$lastpageseen = $DB->get_field('lesson_pages', 'nextpageid', array('id' => $attempt->pageid))) {
- // no nextpage go to end of lesson
- $lastpageseen = LESSON_EOL;
- }
- } else {
- $lastpageseen = $jumpto;
+ $attempt = end($corrrectattempts);
+ $jumpto = $DB->get_field('lesson_answers', 'jumpto', array('id' => $attempt->answerid));
+ // convert the jumpto to a proper page id
+ if ($jumpto == 0) { // unlikely value!
+ $lastpageseen = $attempt->pageid;
+ } elseif ($jumpto == LESSON_NEXTPAGE) {
+ if (!$lastpageseen = $DB->get_field('lesson_pages', 'nextpageid', array('id' => $attempt->pageid))) {
+ // no nextpage go to end of lesson
+ $lastpageseen = LESSON_EOL;
}
- break; // only look at the latest correct attempt
+ } else {
+ $lastpageseen = $jumpto;
}
}
Please sign in to comment.
Something went wrong with that request. Please try again.