Browse files

MDL-31832 CLI upgrade will return 0 exit status if no upgrade is needed

Discussed with David, both points were valid but finally
we agreed about to consider the "no upgrade needed" exit
a normal/succesful one, mainly because it keeps previous
behavior the same (exit non-zero only for real errors).
  • Loading branch information...
1 parent 1acc431 commit 4d4e00682b7a7b0aae38ddbcb03098016d7b8e90 @stronk7 stronk7 committed Mar 7, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 admin/cli/upgrade.php
@@ -93,7 +93,7 @@
$newversion = "$release ($version)";
if (!moodle_needs_upgrading()) {
- cli_error(get_string('cliupgradenoneed', 'core_admin', $newversion), 63);
+ cli_error(get_string('cliupgradenoneed', 'core_admin', $newversion), 0);
// Test environment first.

0 comments on commit 4d4e006

Please sign in to comment.