Permalink
Browse files

MDL-32985 cron: Fixing related problem with setting of lastnotifyfailure

Because of a flaw in the logic, lastnotifyfailure was not set unless
there was a failure. This means that after 1 hour of no failures, the
function would execute every cron cycle, which has a pretty high cost
on large sites.
  • Loading branch information...
1 parent 50eb136 commit 4e6fbf663cef70f8d9e7985fc8f79eee1cda9e88 @merrill-oakland merrill-oakland committed Jun 6, 2012
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/cronlib.php
View
6 lib/cronlib.php
@@ -702,11 +702,11 @@ function notify_login_failures() {
//emailing the admins directly rather than putting these through the messaging system
email_to_user($admin,get_admin(), $subject, $body);
}
-
- // Update lastnotifyfailure with current time
- set_config('lastnotifyfailure', time());
}
+ // Update lastnotifyfailure with current time
+ set_config('lastnotifyfailure', time());
+
// Finally, delete all the temp records we have created in cache_flags
$DB->delete_records_select('cache_flags', "flagtype IN ('login_failure_by_ip', 'login_failure_by_info')");

0 comments on commit 4e6fbf6

Please sign in to comment.