MDL-31006 revert partially @ get_config()

The change from null to stdClass() in get_config() was leading to: 1) unit tests not passing. 2) non-equivalent evaluation in conditions (null evals false, stdClassi() evals true)
moodle · Jan 18, 2012 · 4e7397d · 4e7397d
1 parent 9159aeb
commit 4e7397d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/moodlelib.php b/lib/moodlelib.php
@@ -1076,7 +1076,7 @@ function get_config($plugin, $name = NULL) {
         if ($localcfg) {
             return (object)$localcfg;
         } else {
-            return new stdClass();
+            return null;
         }
 
     } else {

diff --git a/lib/simpletest/testfilterconfig.php b/lib/simpletest/testfilterconfig.php
@@ -579,7 +579,7 @@ public function test_filter_delete_all_for_filter() {
         $expectedconfig = new stdClass;
         $expectedconfig->configname = 'Other config value';
         $this->assertEqual($expectedconfig, get_config('filter_other'));
-        $this->assertFalse(get_config('filter_name'));
+        $this->assertNull(get_config('filter_name'));
     }
 
     public function test_filter_delete_all_for_context() {