MDL-15184: fix sql injection vulnerability

moodle · Jul 1, 2008 · 4fc304c · 4fc304c
1 parent 8fd3d38
commit 4fc304c
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/mod/hotpot/report.php b/mod/hotpot/report.php
@@ -377,10 +377,14 @@ function hotpot_delete_selected_attempts(&$hotpot, $del) {
             $select = "hotpot='$hotpot->id' AND status=".HOTPOT_STATUS_ABANDONED;
             break;
         case 'selection':
-            $ids = (array)data_submitted();
-            unset($ids['del']);
-            unset($ids['id']);
-            if (!empty($ids)) {
+            $ids = array();
+            $data = (array)data_submitted();
+            foreach ($data as $name => $value) {
+                if (preg_match('/^box\d+$/', $name)) {
+                    $ids[] = intval($value);
+                }
+            }
+            if (count($ids)) {
                 $select = "hotpot='$hotpot->id' AND clickreportid IN (".implode(',', $ids).")";
             }
             break;