MDL-39283 GIFT and XML question export broken for unsupported qtypes

Do no write any data to the export for unsupported qtypes
moodle · Apr 23, 2013 · 5312d1f · 5312d1f
1 parent dd8e2dd
commit 5312d1f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/question/format/gift/format.php b/question/format/gift/format.php
@@ -719,10 +719,6 @@ public function writequestion($question) {
             // Check for plugins
             if ($out = $this->try_exporting_using_qtypes($question->qtype, $question)) {
                 $expout .= $out;
-            } else {
-                $expout .= "Question type $question->qtype is not supported\n";
-                echo $OUTPUT->notification(get_string('nohandler', 'qformat_gift',
-                        question_bank::get_qtype_name($question->qtype)));
             }
         }
 

diff --git a/question/format/xml/format.php b/question/format/xml/format.php
@@ -1095,6 +1095,7 @@ protected function presave_process($content) {
     public function writequestion($question) {
         global $CFG, $OUTPUT;
 
+        $invalidquestion = false;
         $fs = get_file_storage();
         $contextid = $question->contextid;
         // Get files used by the questiontext.
@@ -1402,11 +1403,12 @@ public function writequestion($question) {
                 break;
 
             default:
-                // try support by optional plugin
+                // Try support by optional plugin.
                 if (!$data = $this->try_exporting_using_qtypes($question->qtype, $question)) {
-                    notify(get_string('unsupportedexport', 'qformat_xml', $question->qtype));
+                    $invalidquestion = true;
+                } else {
+                    $expout .= $data;
                 }
-                $expout .= $data;
         }
 
         // Output any hints.
@@ -1427,8 +1429,11 @@ public function writequestion($question) {
 
         // close the question tag
         $expout .= "  </question>\n";
-
-        return $expout;
+        if ($invalidquestion) {
+            return '';
+        } else {
+            return $expout;
+        }
     }
 
     public function write_answers($answers) {