Permalink
Browse files

MDL-50357 groups: remove pointless option of groups_delete_group_members

  • Loading branch information...
danpoltawski committed Dec 30, 2015
1 parent 38c67d2 commit 53a2405c9c9a2cb0414e36df3667acec0214cd40
Showing with 5 additions and 7 deletions.
  1. +3 −7 group/lib.php
  2. +2 −0 lib/upgrade.txt
View
@@ -565,10 +565,10 @@ function groups_delete_grouping($groupingorid) {
*
* @param int $courseid
* @param int $userid 0 means all users
* @param bool $showfeedback
* @param bool $unused - formerly $showfeedback, is no longer used.
* @return bool success
*/
function groups_delete_group_members($courseid, $userid=0, $showfeedback=false) {
function groups_delete_group_members($courseid, $userid=0, $unused=false) {
global $DB, $OUTPUT;
// Get the users in the course which are in a group.
@@ -598,10 +598,6 @@ function groups_delete_group_members($courseid, $userid=0, $showfeedback=false)
$eventdata->userid = $userid;
events_trigger_legacy('groups_members_removed', $eventdata);
if ($showfeedback) {
echo $OUTPUT->notification(get_string('deleted').' - '.get_string('groupmembers', 'group'), 'notifysuccess');
}
return true;
}
@@ -1080,4 +1076,4 @@ function groups_sync_with_enrolment($enrolname, $courseid = 0, $gidfield = 'cust
$rs->close();
return $affectedusers;
}
}
View
@@ -31,6 +31,8 @@ information provided here is intended especially for developers.
custom user filters. Similar deprecations in existing user_filter_* classes.
* table_default_export_format_parent::table_default_export_format_parent() is
deprecated, use parent::__construct() in extending classes.
* groups_delete_group_members() $showfeedback parameter has been removed and is no longer
respected. Users of this function should output their own feedback if required.
=== 3.0 ===

0 comments on commit 53a2405

Please sign in to comment.