From 68f41b26b8ce4dc86f136988c9e9dc4f16e4623a Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Thu, 3 Apr 2014 11:07:01 +0800 Subject: [PATCH] MDL-43021 course: corrections to the shortname and idnumber uniqueness validation --- course/lib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/course/lib.php b/course/lib.php index 1fb142189f606..2937e181f3c09 100644 --- a/course/lib.php +++ b/course/lib.php @@ -2377,14 +2377,14 @@ function update_course($data, $editoroptions = NULL) { // Check we don't have a duplicate shortname. if (!empty($data->shortname) && $oldcourse->shortname != $data->shortname) { - if ($DB->record_exists('course', array('shortname' => $data->shortname))) { + if ($DB->record_exists_sql('SELECT id from {course} WHERE shortname = ? AND id <> ?', array($data->shortname, $data->id))) { throw new moodle_exception('shortnametaken', '', '', $data->shortname); } } // Check we don't have a duplicate idnumber. if (!empty($data->idnumber) && $oldcourse->idnumber != $data->idnumber) { - if ($DB->record_exists('course', array('idnumber' => $data->idnumber))) { + if ($DB->record_exists_sql('SELECT id from {course} WHERE idnumber = ? AND id <> ?', array($data->idnumber, $data->id))) { throw new moodle_exception('idnumbertaken', 'error'); } }