Navigation Menu

Skip to content

Commit

Permalink
MDL-32985 cron: Fixing related problem with setting of lastnotifyfailure
Browse files Browse the repository at this point in the history
Because of a flaw in the logic, lastnotifyfailure was not set unless
there was a failure. This means that after 1 hour of no failures, the
function would execute every cron cycle, which has a pretty high cost
on large sites.
  • Loading branch information
ericmerrill committed Jun 6, 2012
1 parent 4a5be0e commit 54c2756
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/cronlib.php
Expand Up @@ -711,11 +711,11 @@ function notify_login_failures() {
//emailing the admins directly rather than putting these through the messaging system
email_to_user($admin,get_admin(), $subject, $body);
}

// Update lastnotifyfailure with current time
set_config('lastnotifyfailure', time());
}

// Update lastnotifyfailure with current time
set_config('lastnotifyfailure', time());

// Finally, delete all the temp records we have created in cache_flags
$DB->delete_records_select('cache_flags', "flagtype IN ('login_failure_by_ip', 'login_failure_by_info')");

Expand Down

0 comments on commit 54c2756

Please sign in to comment.