Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

mnet: remove extra paranoid check in the mnet xmlrpc client

 - Donal - this needs review. I don't think we can assume the remote
   end has the same service/method mappings we do. This will preclude
   us from using stuff we don't have installed the "server" code for
   but perhaps we do have the client code for.
  • Loading branch information...
commit 56eec24397fdc672a6e062db5aa6c0a7eeda5bc7 1 parent 15e4772
martinlanghoff authored
Showing with 5 additions and 0 deletions.
  1. +5 −0 mnet/xmlrpc/client.php
5 mnet/xmlrpc/client.php
View
@@ -141,6 +141,10 @@ function send($mnet_peer) {
if (!empty($CFG->mnet_all_hosts_id)) {
$id_list .= ', '.$CFG->mnet_all_hosts_id;
}
+
+ /*** TODO: Review MartinL notes - This is bogus AFAICT,
+ *** because we cannot be certain that the remote
+ *** host has the same plugins or modules we do
// Find methods that we subscribe to on this host
$sql = "
SELECT
@@ -161,6 +165,7 @@ function send($mnet_peer) {
// TODO: Handle attempt to call not-permitted method
return false;
}
+ *** END_OF_TODO */
}
$this->requesttext = xmlrpc_encode_request($this->method, $this->params);
Please sign in to comment.
Something went wrong with that request. Please try again.