Permalink
Browse files

MDL-38194 Files: Allow download of large backup files

The PHP readfile function does not work for files more than 2GB.
This commit provides a wrapper that can be used so that files less
than 2GB are sent with readfile, and files larger than 2GB are
sent manually.

The change applies to all uses of pluginfile.php, although in
reality, backup files are probably the only ones likely to be more
than two gigabytes.
  • Loading branch information...
1 parent 444433b commit 5912c3e43e35a92c8e4579c5afac8e0246104dbb @sammarshallou sammarshallou committed Sep 10, 2013
Showing with 39 additions and 2 deletions.
  1. +38 −1 lib/filelib.php
  2. +1 −1 lib/filestorage/stored_file.php
View
@@ -2002,6 +2002,43 @@ function send_header_404() {
}
/**
+ * The readfile function can fail when files are larger than 2GB (even on 64-bit
+ * platforms). This wrapper uses readfile for small files and custom code for
+ * large ones.
+ *
+ * @param string $path Path to file
+ * @param int $filesize Size of file (if left out, will get it automatically)
+ * @return int|bool Size read (will always be $filesize) or false if failed
+ */
+function readfile_allow_large($path, $filesize = -1) {
+ // Automatically get size if not specified.
+ if ($filesize === -1) {
+ $filesize = filesize($path);
+ }
+ if ($filesize <= 2147483647) {
+ // If the file is up to 2^31 - 1, send it normally using readfile.
+ return readfile($path);
+ } else {
+ // For large files, read and output in 64KB chunks.
+ $handle = fopen($path, 'r');
+ if ($handle === false) {
+ return false;
+ }
+ $left = $filesize;
+ while ($left > 0) {
+ $size = min($left, 65536);
+ $buffer = fread($handle, $size);
+ if ($buffer === false) {
+ return false;
+ }
+ echo $buffer;
+ $left -= $size;
+ }
+ return $filesize;
+ }
+}
+
+/**
* Enhanced readfile() with optional acceleration.
* @param string|stored_file $file
* @param string $mimetype
@@ -2123,7 +2160,7 @@ function readfile_accel($file, $mimetype, $accelerate) {
if (is_object($file)) {
$file->readfile();
} else {
- readfile($file);
+ readfile_allow_large($file, $filesize);
}
}
@@ -407,7 +407,7 @@ public function readfile() {
throw new file_exception('storedfilecannotread', '', $path);
}
}
- readfile($path);
+ readfile_allow_large($path, $this->get_filesize());
}
/**

0 comments on commit 5912c3e

Please sign in to comment.