Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

MDL-30344 lti - Hiding roster permission from the UI as it's not impl…

…emented in LTI 1.1.
  • Loading branch information...
commit 59fc5c5404f3295de872ece3aa6bcf11a991c077 1 parent 038d8e3
scriby authored stronk7 committed
2  mod/lti/ajax.php
@@ -63,7 +63,7 @@
63 63
                 FROM {lti_types_config}
64 64
                 WHERE
65 65
                     typeid = :typeid
66  
-                AND name IN (\'sendname\', \'sendemailaddr\', \'acceptgrades\', \'allowroster\')
  66
+                AND name IN (\'sendname\', \'sendemailaddr\', \'acceptgrades\')
67 67
             ';
68 68
                         
69 69
             $privacyconfigs = $DB->get_records_sql($query, array('typeid' => $toolid));
6  mod/lti/edit_form.php
@@ -126,9 +126,9 @@ public function definition() {
126 126
         $mform->addHelpButton('lti_acceptgrades', 'accept_grades_admin', 'lti');
127 127
 
128 128
         // Add grading preferences fieldset where the tool is allowed to retrieve rosters
129  
-        $mform->addElement('select', 'lti_allowroster', get_string('share_roster_admin', 'lti'), $options);
130  
-        $mform->setDefault('lti_allowroster', '2');
131  
-        $mform->addHelpButton('lti_allowroster', 'share_roster_admin', 'lti');
  129
+        //$mform->addElement('select', 'lti_allowroster', get_string('share_roster_admin', 'lti'), $options);
  130
+        //$mform->setDefault('lti_allowroster', '2');
  131
+        //$mform->addHelpButton('lti_allowroster', 'share_roster_admin', 'lti');
132 132
 
133 133
         $mform->addElement('checkbox', 'lti_forcessl', ' ', ' ' . get_string('force_ssl', 'lti'), $options);
134 134
         $mform->setDefault('lti_forcessl', '0');
6  mod/lti/mod_form.js
@@ -184,8 +184,7 @@
184 184
                 toolInfo = {
185 185
                     sendname: M.mod_lti.LTI_SETTING_DELEGATE,
186 186
                     sendemailaddr: M.mod_lti.LTI_SETTING_DELEGATE,
187  
-                    acceptgrades: M.mod_lti.LTI_SETTING_DELEGATE,
188  
-                    allowroster: M.mod_lti.LTI_SETTING_DELEGATE
  187
+                    acceptgrades: M.mod_lti.LTI_SETTING_DELEGATE
189 188
                 }
190 189
             }
191 190
             
@@ -196,8 +195,7 @@
196 195
             var privacyControls = {
197 196
                 sendname: Y.one('input[name=instructorchoicesendname]'),
198 197
                 sendemailaddr: Y.one('input[name=instructorchoicesendemailaddr]'),
199  
-                acceptgrades: Y.one('input[name=instructorchoiceacceptgrades]'),
200  
-                allowroster: Y.one('input[name=instructorchoiceallowroster]')
  198
+                acceptgrades: Y.one('input[name=instructorchoiceacceptgrades]')
201 199
             };
202 200
             
203 201
             //Store a copy of user entered privacy settings as we may overwrite them
6  mod/lti/mod_form.php
@@ -164,9 +164,9 @@ public function definition() {
164 164
         $mform->setDefault('instructorchoiceacceptgrades', '1');
165 165
         $mform->addHelpButton('instructorchoiceacceptgrades', 'accept_grades', 'lti');
166 166
 
167  
-        $mform->addElement('checkbox', 'instructorchoiceallowroster', ' ', ' ' . get_string('share_roster', 'lti'));
168  
-        $mform->setDefault('instructorchoiceallowroster', '1');
169  
-        $mform->addHelpButton('instructorchoiceallowroster', 'share_roster', 'lti');
  167
+        //$mform->addElement('checkbox', 'instructorchoiceallowroster', ' ', ' ' . get_string('share_roster', 'lti'));
  168
+        //$mform->setDefault('instructorchoiceallowroster', '1');
  169
+        //$mform->addHelpButton('instructorchoiceallowroster', 'share_roster', 'lti');
170 170
 
171 171
         //-------------------------------------------------------------------------------
172 172
 

0 notes on commit 59fc5c5

Please sign in to comment.
Something went wrong with that request. Please try again.