From 5b662f33e2840d6af8d5cef7c8f6fc3b95b20464 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Mon, 26 Mar 2012 17:43:18 +0100 Subject: [PATCH] MDL-32201 question export: use qformat_xml::write_answer in base class Without this, images in answers were not being written to the export file for questions using extra_answer_fields. --- question/type/questiontypebase.php | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/question/type/questiontypebase.php b/question/type/questiontypebase.php index 15a4e50c3b066..9c313ea5041e2 100644 --- a/question/type/questiontypebase.php +++ b/question/type/questiontypebase.php @@ -1005,21 +1005,15 @@ public function export_to_xml($question, $format, $extra=null) { array_shift($extraanswersfields); } foreach ($question->options->answers as $answer) { - // TODO this should be re-factored to use $format->write_answer(). - $percent = 100 * $answer->fraction; - $expout .= " format($answer->answerformat)}>\n"; - $expout .= $format->writetext($answer->answer, 3, false); - $expout .= " format($answer->feedbackformat)}>\n"; - $expout .= $format->writetext($answer->feedback, 4, false); - $expout .= " \n"; + $extra = ''; if (is_array($extraanswersfields)) { foreach ($extraanswersfields as $field) { $exportedvalue = $format->xml_escape($answer->$field); - $expout .= " <{$field}>{$exportedvalue}\n"; + $extra .= " <{$field}>{$exportedvalue}\n"; } } - $expout .= " \n"; + $expout .= $format->write_answer($answer, $extra); } return $expout; }