Permalink
Browse files

MDL-33448 enrol_manual: Reordered things to improve JS performance wh…

…en enrolling users
  • Loading branch information...
Sam Hemelryk
Sam Hemelryk committed Oct 3, 2012
1 parent 9958465 commit 5c5b2999cb1ba847e203b0e684ec32da57aa2f83
Showing with 5 additions and 3 deletions.
  1. +5 −3 enrol/manual/yui/quickenrolment/quickenrolment.js
@@ -149,6 +149,11 @@ YUI.add('moodle-enrol_manual-quickenrolment', function(Y) {
}
this.get(UEP.BASE).one('.'+CSS.SEARCHOPTIONS+' .'+CSS.COLLAPSIBLEHEADING).one('img').setAttribute('src', M.util.image_url(collapsedimage, 'moodle'));
+ this.get(UEP.BASE).one('.'+CSS.SEARCHOPTIONS+' .'+CSS.COLLAPSIBLEHEADING).once('click', function() {
+ // We want to do this just once, the first time the controls are shown.
+ this.populateStartDates();
+ this.populateDuration();
+ }, this);
this.get(UEP.BASE).one('.'+CSS.SEARCHOPTIONS+' .'+CSS.COLLAPSIBLEHEADING).on('click', function(){
this.get(UEP.BASE).one('.'+CSS.SEARCHOPTIONS+' .'+CSS.COLLAPSIBLEHEADING).toggleClass(CSS.ACTIVE);
this.get(UEP.BASE).one('.'+CSS.SEARCHOPTIONS+' .'+CSS.COLLAPSIBLEAREA).toggleClass(CSS.HIDDEN);
@@ -158,10 +163,7 @@ YUI.add('moodle-enrol_manual-quickenrolment', function(Y) {
this.get(UEP.BASE).one('.'+CSS.SEARCHOPTIONS+' .'+CSS.COLLAPSIBLEHEADING).one('img').setAttribute('src', M.util.image_url('t/expanded', 'moodle'));
}
}, this);
-
this.populateAssignableRoles();
- this.populateStartDates();
- this.populateDuration();
},
populateAssignableRoles : function() {
this.on('assignablerolesloaded', function(){

0 comments on commit 5c5b299

Please sign in to comment.