Permalink
Browse files

MDL-34573 accessibility compliance for tag: Add forform input text an…

…d select tag
  • Loading branch information...
1 parent 555112a commit 5da3e35ed365614285bbe45479cd872c065a4c53 @rwijaya rwijaya committed Jul 27, 2012
Showing with 12 additions and 6 deletions.
  1. +7 −4 tag/coursetags_edit.php
  2. +5 −2 tag/manage.php
@@ -141,11 +141,12 @@
<div class="coursetag_edit_centered">
<div class="coursetag_edit_row">
<div class="coursetag_edit_left">
- $edittagthisunit
+ <label for="coursetag_new_tag">$edittagthisunit</label>
</div>
<div class="coursetag_edit_right">
<div class="coursetag_form_input1">
- <input type="text" name="coursetag_sug_keyword" class="coursetag_form_input1a" disabled="disabled" />
+ <label clas="accesshide" for="coursetag_sug_keyword">$edittagthisunit</label>
+ <input type="text" name="coursetag_sug_keyword" id="coursetag_sug_keyword" class="coursetag_form_input1a" disabled="disabled" />
</div>
<div class="coursetag_form_input2">
<input type="text" name="coursetag_new_tag" id="coursetag_new_tag" class="coursetag_form_input2a"
@@ -164,10 +165,12 @@
$outstr .= <<<EOT1
<div class="coursetag_edit_row">
<div class="coursetag_edit_left">
- $editdeletemytag
+ <label for="del_tag">
+ $editdeletemytag
+ </label>
</div>
<div class="coursetag_edit_right">
- <select name="del_tag">
+ <select id="del_tag" name="del_tag">
$selectoptions
</select>
</div>
View
@@ -260,8 +260,10 @@
$flag = $tag->flag;
$timemodified = format_time(time() - $tag->timemodified);
$checkbox = '<input type="checkbox" name="tagschecked[]" value="'.$tag->id.'" />';
- $text = '<input type="text" name="newname['.$tag->id.']" />';
- $tagtype = html_writer::select($existing_tagtypes, 'tagtypes['.$tag->id.']', $tag->tagtype, false);
+ $text = html_writer::label(get_string('newname', 'tag'), 'newname_' . $tag->id, false, array('class' => 'accesshide'));
+ $text .= '<input type="text" id="newname_' . $tag->id. '" name="newname['.$tag->id.']" />';
+ $tagtype = html_writer::label(get_string('tagtype', 'tag'), 'menutagtypes'. $tag->id, false, array('class' => 'accesshide'));
+ $tagtype .= html_writer::select($existing_tagtypes, 'tagtypes['.$tag->id.']', $tag->tagtype, false, array('id' => 'menutagtypes'. $tag->id));
//if the tag if flagged, highlight it
if ($tag->flag > 0) {
@@ -283,6 +285,7 @@
echo '<input type="button" onclick="checknone()" value="'.get_string('deselectall').'" /> ';
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" /> ';
echo '<br/><br/>';
+ echo html_writer::label(get_string('withselectedtags', 'tag'), 'menuformaction', false, array('class' => 'accesshide'));
echo '<select id="menuformaction" name="action">
<option value="" selected="selected">'. get_string('withselectedtags', 'tag') .'</option>
<option value="reset">'. get_string('resetflag', 'tag') .'</option>

0 comments on commit 5da3e35

Please sign in to comment.