MDL-18229 gradebook: Updating code to Moodle standard.

moodle · Oct 14, 2014 · 65c134f · 65c134f
1 parent 92c61fe
commit 65c134f
Show file tree

Hide file tree

Showing 10 changed files with 328 additions and 326 deletions.
diff --git a/grade/report/singleview/classes/lib.php b/grade/report/singleview/classes/lib.php
@@ -18,7 +18,7 @@
 /**
  * The gradebook simple view - base class for the table
  *
- * @package   singleview
+ * @package   gradereport_singleview
  * @copyright 2014 Moodle Pty Ltd (http://moodle.com)
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
@@ -213,7 +213,9 @@ public function process($data) {
             $oldname = "old$name";
 
             $posted = $data->$name;
-            $oldvalue = $data->$oldname;
+            if (isset($data->$oldname)) {
+                $oldvalue = $data->$oldname;
+            }
 
             $format = $element->determine_format();
 
@@ -240,8 +242,6 @@ public function process($data) {
         $event_data->post_data = $data;
         $event_data->instance = $this;
 
-        qe_events_trigger(get_class($this) . '_edited', $event_data);
-
         return $event_data->warnings;
     }
 
@@ -378,8 +378,6 @@ public function html() {
         $data->table = $table;
         $data->instance = $this;
 
-        qe_events_trigger($underlying . '_table_built', $data);
-
         $button_attr = array('class' => 'singleview_buttons submit');
         $button_html = implode(' ', $this->buttons());