Permalink
Browse files

MDL-40259 - For SCORM reports limit fields returned from

get_users_by_capability to user ID to decrease memory utilization
  • Loading branch information...
1 parent 969e5b5 commit 66d0022594586cd0fe622963a3ffd89f06962ad3 Tim Gus committed with Tim Gusak Jun 10, 2013
Showing with 8 additions and 4 deletions.
  1. +4 −2 mod/scorm/report/basic/report.php
  2. +4 −2 mod/scorm/report/interactions/report.php
@@ -82,21 +82,23 @@ function display($scorm, $cm, $course, $download) {
if (empty($currentgroup)) {
// all users who can attempt scoes
- if (!$students = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', '', '', '', '', '', '', false)) {
+ if (!$students = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', 'u.id', '', '', '', '', '', false)) {
echo $OUTPUT->notification(get_string('nostudentsyet'));
$nostudents = true;
$allowedlist = '';
} else {
$allowedlist = array_keys($students);
}
+ unset($students);
} else {
// all users who can attempt scoes and who are in the currently selected group
- if (!$groupstudents = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', '', '', '', '', $currentgroup, '', false)) {
+ if (!$groupstudents = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', 'u.id', '', '', '', $currentgroup, '', false)) {
echo $OUTPUT->notification(get_string('nostudentsingroup'));
$nostudents = true;
$groupstudents = array();
}
$allowedlist = array_keys($groupstudents);
+ unset($groupstudents);
}
if ( !$nostudents ) {
@@ -96,21 +96,23 @@ function display($scorm, $cm, $course, $download) {
if (empty($currentgroup)) {
// all users who can attempt scoes
- if (!$students = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', '', '', '', '', '', '', false)) {
+ if (!$students = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', 'u.id', '', '', '', '', '', false)) {
echo $OUTPUT->notification(get_string('nostudentsyet'));
$nostudents = true;
$allowedlist = '';
} else {
$allowedlist = array_keys($students);
}
+ unset($students);
} else {
// all users who can attempt scoes and who are in the currently selected group
- if (!$groupstudents = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', '', '', '', '', $currentgroup, '', false)) {
+ if (!$groupstudents = get_users_by_capability($contextmodule, 'mod/scorm:savetrack', 'u.id', '', '', '', $currentgroup, '', false)) {
echo $OUTPUT->notification(get_string('nostudentsingroup'));
$nostudents = true;
$groupstudents = array();
}
$allowedlist = array_keys($groupstudents);
+ unset($groupstudents);
}
if ( !$nostudents ) {
// Now check if asked download of data

0 comments on commit 66d0022

Please sign in to comment.