MDL-15268 "Content for Quiz Statistics report table" fixed a bug wher…

…e every a row was added to the table for every time a subquestion was attempted.
moodle · Jul 20, 2008 · 66eb3b5 · 66eb3b5
1 parent 375381a
commit 66eb3b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/mod/quiz/report/statistics/qstats.php b/mod/quiz/report/statistics/qstats.php
@@ -127,8 +127,8 @@ function process_states(){
                         $subquestionstats[$itemid]->differentweights = true;
                     }
                     $this->_initial_states_walker($state, $subquestionstats[$itemid], false);
-                    $subquestionstats[$itemid]->usedin[] = $state->question;
-                    $this->questions[$state->question]->_stats->subitems[] = $itemid;
+                    $subquestionstats[$itemid]->usedin[$state->question] = $state->question;
+                    $this->questions[$state->question]->_stats->subitems[$itemid] = $itemid;
                 }
             }
         }

diff --git a/mod/quiz/report/statistics/report.php b/mod/quiz/report/statistics/report.php
@@ -274,6 +274,7 @@ function display($quiz, $cm, $course) {
         if (isset($qstats)){
             foreach ($qstats->questions as $question){
                 $table->add_data_keyed($table->format_row($question));
+                ksort($question->_stats->subitems);
                 foreach ($question->_stats->subitems as $itemid){
                     $table->add_data_keyed($table->format_row($qstats->subquestions[$itemid]));
                 }