Permalink
Browse files

Incomplete user record (the one where the username is still 'changeme…

…') should not be included in user listing. See bug 4570. For some reason this script is not using get_users() but is instead constructing its own sql, so the change to get_users() had to be duplicated here.
  • Loading branch information...
1 parent 6bff045 commit 6ac0909983322c3beac42c7bca8d87c6637db9ff gustav_delius committed Oct 5, 2006
Showing with 2 additions and 1 deletion.
  1. +2 −1 admin/roles/assign.php
View
@@ -182,12 +182,13 @@
if ($roleid) { /// prints a form to swap roles
/// Get all existing participants in this context.
+ // Why is this not done with get_users???
if (!$contextusers = get_role_users($roleid, $context, false, 'u.id, u.firstname, u.lastname, u.email')) {
$contextusers = array();
}
- $select = "username <> 'guest' AND deleted = 0 AND confirmed = 1";
+ $select = "username <> 'guest' AND username <> 'changeme' AND deleted = 0 AND confirmed = 1";
$usercount = count_records_select('user', $select) - count($contextusers);

0 comments on commit 6ac0909

Please sign in to comment.