Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

MDL-43511 do not cache the MUC cache in question code

  • Loading branch information...
commit 6b4ae63ac8990a4560b95cce2d97da1ffe62ee1f 1 parent 0e088ae
@skodak skodak authored
Showing with 2 additions and 7 deletions.
  1. +2 −7 question/engine/bank.php
View
9 question/engine/bank.php
@@ -439,9 +439,6 @@ class question_finder implements cache_data_source {
/** @var question_finder the singleton instance of this class. */
protected static $questionfinder = null;
- /** @var cache the question definition cache. */
- protected $cache = null;
-
/**
* @return question_finder a question finder.
*/
@@ -461,10 +458,8 @@ public static function get_instance_for_cache(cache_definition $definition) {
* @return get the question definition cache we are using.
*/
protected function get_data_cache() {
- if ($this->cache == null) {
- $this->cache = cache::make('core', 'questiondata');
- }
- return $this->cache;
+ // Do not double cache here because it may break cache resetting.
+ return cache::make('core', 'questiondata');
}
/**
Please sign in to comment.
Something went wrong with that request. Please try again.