Permalink
Browse files

MDL-31731 Advanced Grading: Marking Guide display scale warning for h…

…igher max grade as well as lower.
  • Loading branch information...
1 parent b4b1d49 commit 6c2092582766a3b5ce7439be63abbc4b8c4df439 @danmarsden danmarsden committed May 3, 2012
Showing with 2 additions and 2 deletions.
  1. +1 −1 grade/grading/form/guide/lang/en/gradingform_guide.php
  2. +1 −1 grade/grading/form/guide/renderer.php
@@ -55,7 +55,7 @@
$string['err_noshortname'] = 'Criterion name can not be empty';
$string['err_scoreinvalid'] = 'The score given to {$a->criterianame} is not valid, the max score is: {$a->maxscore}';
$string['gradingof'] = '{$a} grading';
-$string['guidemappingexplained'] = 'WARNING: Your marking guide has a maximum grade of <b>{$a->maxscore} points</b> but the maximum grade set in your activity is {$a->modulegrade} The maximum score set in your marking guide will be scaled up to the maximum grade in the module.<br />
+$string['guidemappingexplained'] = 'WARNING: Your marking guide has a maximum grade of <b>{$a->maxscore} points</b> but the maximum grade set in your activity is {$a->modulegrade} The maximum score set in your marking guide will be scaled to the maximum grade in the module.<br />
Intermediate scores will be converted respectively and rounded to the nearest available grade.';
$string['guidenotcompleted'] = 'Please provide a valid grade for each criterion';
$string['guideoptions'] = 'Marking guide options';
@@ -625,7 +625,7 @@ public function display_guide_mapping_explained($scores) {
if (!$scores) {
return $html;
}
- if (isset($scores['modulegrade']) && $scores['maxscore'] < $scores['modulegrade']) {
+ if (isset($scores['modulegrade']) && $scores['maxscore'] != $scores['modulegrade']) {
$html .= $this->box(html_writer::tag('div', get_string('guidemappingexplained', 'gradingform_guide', (object)$scores))
, 'generalbox gradingform_guide-error');
}

0 comments on commit 6c20925

Please sign in to comment.