Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
MDL-52901 mod_assign: Check due dates in external save_submission
  • Loading branch information
jleyva authored and stronk7 committed Mar 7, 2016
1 parent ae66ed2 commit 711f946
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
9 changes: 6 additions & 3 deletions mod/assign/externallib.php
Expand Up @@ -1681,9 +1681,12 @@ public static function save_submission($assignmentid, $plugindata) {

$notices = array();

$submissiondata = (object)$params['plugindata'];

$assignment->save_submission($submissiondata, $notices);
if (!$assignment->submissions_open($USER->id)) {
$notices[] = get_string('duedatereached', 'assign');
} else {
$submissiondata = (object)$params['plugindata'];
$assignment->save_submission($submissiondata, $notices);
}

$warnings = array();
foreach ($notices as $notice) {
Expand Down
10 changes: 10 additions & 0 deletions mod/assign/tests/externallib_test.php
Expand Up @@ -946,6 +946,16 @@ public function test_save_submission() {

$this->assertEquals(0, count($result));

// Set up a due and cutoff passed date.
$instance->duedate = time() - WEEKSECS;
$instance->cutoffdate = time() - WEEKSECS;
$DB->update_record('assign', $instance);

$result = mod_assign_external::save_submission($instance->id, $submissionpluginparams);
$result = external_api::clean_returnvalue(mod_assign_external::save_submission_returns(), $result);

$this->assertCount(1, $result);
$this->assertEquals(get_string('duedatereached', 'assign'), $result[0]['item']);
}

/**
Expand Down

0 comments on commit 711f946

Please sign in to comment.