Permalink
Browse files

MDL-29818: Improve error message when a grade has no answer

  • Loading branch information...
1 parent 263c528 commit 73ebb5d7ab95b0547411723351db05cbe628002d @andrewnicols andrewnicols committed Oct 18, 2011
View
6 question/type/multichoice/edit_multichoice_form.php
@@ -109,9 +109,13 @@ public function validation($data, $files) {
foreach ($answers as $key => $answer) {
//check no of choices
$trimmedanswer = trim($answer['text']);
- if (empty($trimmedanswer)) {
+ $fraction = (float) $data['fraction'][$key];
+ if (empty($trimmedanswer) && empty($fraction)) {
continue;
}
+ if (empty($trimmedanswer)) {
+ $errors['fraction['.$key.']'] = get_string('errgradesetanswerblank', 'qtype_multichoice');
+ }
$answercount++;
View
1 question/type/multichoice/lang/en/qtype_multichoice.php
@@ -41,6 +41,7 @@
$string['correctansweris'] = 'The correct answer is: {$a}.';
$string['correctfeedback'] = 'For any correct response';
$string['editingmultichoice'] = 'Editing a Multiple choice question';
+$string['errgradesetanswerblank'] = 'Grade set, but the Answer is blank';
$string['errfractionsaddwrong'] = 'The positive grades you have chosen do not add up to 100%<br />Instead, they add up to {$a}%';
$string['errfractionsnomax'] = 'One of the choices should be 100%, so that it is<br />possible to get a full grade for this question.';
$string['feedback'] = 'Feedback';

0 comments on commit 73ebb5d

Please sign in to comment.