Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-32639 files: Removing '0' start folder in archives created with f…

…ilemanager

Signed-off-by: Vadim Dvorovenko <vadimon@mail.ru>

Conflicts:

	lib/filestorage/zip_archive.php
  • Loading branch information...
commit 785e3deb4d12bba6b1f444ac6fa3a3e01539cd73 1 parent 0b7c52d
@vadimonus vadimonus authored FMCorz committed
View
10 lib/filestorage/zip_archive.php
@@ -361,7 +361,7 @@ public function add_directory($localname) {
if (!isset($this->za)) {
return false;
}
- $localname = ltrim($localname, '/'). '/';
+ $localname = trim($localname, '/'). '/';
$localname = $this->mangle_pathname($localname);
if ($localname === '/') {
@@ -369,10 +369,12 @@ public function add_directory($localname) {
return false;
}
- if (!$this->za->addEmptyDir($localname)) {
- return false;
+ if ($localname !== '') {
+ if (!$this->za->addEmptyDir($localname)) {
+ return false;
+ }
+ $this->modified = true;
}
- $this->modified = true;
return true;
}
View
7 repository/draftfiles_ajax.php
@@ -219,8 +219,11 @@
$file = $fs->get_file($user_context->id, 'user', 'draft', $draftid, $filepath, '.');
$parent_path = $file->get_parent_directory()->get_filepath();
+
+ $filepath = explode('/', trim($file->get_filepath(), '/'));
+ $filepath = array_pop($filepath);
- if ($newfile = $zipper->archive_to_storage(array($file), $user_context->id, 'user', 'draft', $draftid, $parent_path, $filepath.'.zip', $USER->id)) {
+ if ($newfile = $zipper->archive_to_storage(array($filepath => $file), $user_context->id, 'user', 'draft', $draftid, $parent_path, $filepath.'.zip', $USER->id)) {
$return = new stdClass();
$return->filepath = $parent_path;
echo json_encode($return);
@@ -251,7 +254,7 @@
// archive compressed file to an unused draft area
$newdraftitemid = file_get_unused_draft_itemid();
- if ($newfile = $zipper->archive_to_storage(array($stored_file), $user_context->id, 'user', 'draft', $newdraftitemid, '/', $filename, $USER->id)) {
+ if ($newfile = $zipper->archive_to_storage(array('/' => $stored_file), $user_context->id, 'user', 'draft', $newdraftitemid, '/', $filename, $USER->id)) {
$return = new stdClass();
$return->fileurl = moodle_url::make_draftfile_url($newdraftitemid, '/', $filename)->out();
$return->filepath = $parent_path;
View
8 repository/draftfiles_manager.php
@@ -147,7 +147,7 @@
$filename = get_string('files').'.zip';
}
- if ($newfile = $zipper->archive_to_storage(array($file), $user_context->id, 'user', 'draft', $itemid, $parent_path, $filename, $USER->id)) {
+ if ($newfile = $zipper->archive_to_storage(array('/' => $file), $user_context->id, 'user', 'draft', $itemid, $parent_path, $filename, $USER->id)) {
$fileurl = moodle_url::make_draftfile_url($itemid, '/', $filename)->out();
header('Location: ' . $fileurl );
} else {
@@ -161,14 +161,16 @@
$file = $fs->get_file($user_context->id, 'user', 'draft', $itemid, $draftpath, '.');
if (!$file->get_parent_directory()) {
$parent_path = '/';
+ $filepath = '/';
$filename = get_string('files').'.zip';
} else {
$parent_path = $file->get_parent_directory()->get_filepath();
$filepath = explode('/', trim($file->get_filepath(), '/'));
- $filename = array_pop($filepath).'.zip';
+ $filepath = array_pop($filepath);
+ $filename = $filepath.'.zip';
}
- $newfile = $zipper->archive_to_storage(array($file), $user_context->id, 'user', 'draft', $itemid, $parent_path, $filename, $USER->id);
+ $newfile = $zipper->archive_to_storage(array($filepath => $file), $user_context->id, 'user', 'draft', $itemid, $parent_path, $filename, $USER->id);
$home_url->param('action', 'browse');
$home_url->param('draftpath', $parent_path);
Please sign in to comment.
Something went wrong with that request. Please try again.