Skip to content
Browse files

MDL-36855 scorm: update to api get_scorm_question_count()

get_scorm_question_count() should return 0 not 1 when no attempt is made in a scorm by any student
  • Loading branch information...
1 parent d63a406 commit 78ac8558e0825f5a06ec5f0d0cfce65bf6129669 @ankitagarwal ankitagarwal committed Jan 3, 2013
Showing with 8 additions and 6 deletions.
  1. +8 −6 mod/scorm/report/reportlib.php
View
14 mod/scorm/report/reportlib.php
@@ -68,14 +68,16 @@ function get_scorm_question_count($scormid) {
$params[] = "cmi.interactions_%.id";
$rs = $DB->get_recordset_select("scorm_scoes_track", $select, $params, 'element');
$keywords = array("cmi.interactions_", ".id");
- foreach ($rs as $record) {
- $num = trim(str_ireplace($keywords, '', $record->element));
- if (is_numeric($num) && $num > $count) {
- $count = $num;
+ if ($rs->valid()) {
+ // Done as interactions start at 0 (do only if we have something to report).
+ $count++;
+ foreach ($rs as $record) {
+ $num = trim(str_ireplace($keywords, '', $record->element));
+ if (is_numeric($num) && $num > $count) {
+ $count = $num;
+ }
}
}
- //done as interactions start at 0
- $count++;
$rs->close(); // closing recordset
return $count;
}

0 comments on commit 78ac855

Please sign in to comment.
Something went wrong with that request. Please try again.