From f09561cbb5783fa70869c20cf359929cb129dc75 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Sun, 29 Jun 2014 18:37:44 -0700 Subject: [PATCH 1/2] MDL-45381 mod_forum: changed event URL for subscription created/deleted events --- mod/forum/classes/event/subscription_created.php | 2 +- mod/forum/classes/event/subscription_deleted.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/forum/classes/event/subscription_created.php b/mod/forum/classes/event/subscription_created.php index e5af00fb11162..19d53ac8903a2 100644 --- a/mod/forum/classes/event/subscription_created.php +++ b/mod/forum/classes/event/subscription_created.php @@ -77,7 +77,7 @@ public static function get_name() { * @return \moodle_url */ public function get_url() { - return new \moodle_url('/mod/forum/view.php', array('f' => $this->other['forumid'])); + return new \moodle_url('/mod/forum/subscribers.php', array('id' => $this->other['forumid'])); } /** diff --git a/mod/forum/classes/event/subscription_deleted.php b/mod/forum/classes/event/subscription_deleted.php index 738a5c0e0ad09..f011059448ccb 100644 --- a/mod/forum/classes/event/subscription_deleted.php +++ b/mod/forum/classes/event/subscription_deleted.php @@ -77,7 +77,7 @@ public static function get_name() { * @return \moodle_url */ public function get_url() { - return new \moodle_url('/mod/forum/view.php', array('f' => $this->other['forumid'])); + return new \moodle_url('/mod/forum/subscribers.php', array('id' => $this->other['forumid'])); } /** From 05c0d19a5d4dfb695c026a6cd549147c5f31993f Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Mon, 30 Jun 2014 23:32:08 -0700 Subject: [PATCH 2/2] MDL-45381 mod_forum: updated unit tests for subscription created/deleted events --- mod/forum/tests/events_test.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/forum/tests/events_test.php b/mod/forum/tests/events_test.php index 4c284dafb979a..61c007c4368ad 100644 --- a/mod/forum/tests/events_test.php +++ b/mod/forum/tests/events_test.php @@ -662,7 +662,7 @@ public function test_subscription_created() { $this->assertEquals($context, $event->get_context()); $expected = array($course->id, 'forum', 'subscribe', "view.php?f={$forum->id}", $forum->id, $forum->cmid); $this->assertEventLegacyLogData($expected, $event); - $url = new \moodle_url('/mod/forum/view.php', array('f' => $forum->id)); + $url = new \moodle_url('/mod/forum/subscribers.php', array('id' => $forum->id)); $this->assertEquals($url, $event->get_url()); $this->assertEventContextNotUsed($event); @@ -759,7 +759,7 @@ public function test_subscription_deleted() { $this->assertEquals($context, $event->get_context()); $expected = array($course->id, 'forum', 'unsubscribe', "view.php?f={$forum->id}", $forum->id, $forum->cmid); $this->assertEventLegacyLogData($expected, $event); - $url = new \moodle_url('/mod/forum/view.php', array('f' => $forum->id)); + $url = new \moodle_url('/mod/forum/subscribers.php', array('id' => $forum->id)); $this->assertEquals($url, $event->get_url()); $this->assertEventContextNotUsed($event);