MDL-57868 mod_feedback: Fix incorrect query parameters order

get_records_menu call get_records using the same params ordering, it is causing a duplicated value error for the first column
moodle · Feb 6, 2017 · 7b48139 · 7b48139
1 parent a04076a
commit 7b48139
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/mod/feedback/lib.php b/mod/feedback/lib.php
@@ -962,10 +962,9 @@ function feedback_get_incomplete_users(cm_info $cm,
 
     //now get all completeds
     $params = array('feedback'=>$cm->instance);
-    if (!$completedusers = $DB->get_records_menu('feedback_completed', $params, '', 'userid,id')) {
+    if (!$completedusers = $DB->get_records_menu('feedback_completed', $params, '', 'id, userid')) {
         return $allusers;
     }
-    $completedusers = array_keys($completedusers);
 
     //now strike all completedusers from allusers
     $allusers = array_diff($allusers, $completedusers);