Skip to content
Browse files

MDL-38387 cache: removed call to plugins API from cache API

  • Loading branch information...
1 parent a3b63be commit 7b9cb736baeaac494237f6ecd01a51d4d1ba19ed @samhemelryk samhemelryk committed
Showing with 14 additions and 5 deletions.
  1. +14 −5 cache/classes/factory.php
View
19 cache/classes/factory.php
@@ -103,7 +103,7 @@ class cache_factory {
* An array of lock plugins.
* @var array
*/
- protected $lockplugins = null;
+ protected $lockplugins = array();
/**
* The current state of the cache API.
@@ -155,7 +155,7 @@ public static function reset() {
$factory->stores = array();
$factory->configs = array();
$factory->definitions = array();
- $factory->lockplugins = null; // MUST be null in order to force its regeneration.
+ $factory->lockplugins = array(); // MUST be null in order to force its regeneration.
// Reset the state to uninitialised.
$factory->state = self::STATE_UNINITIALISED;
}
@@ -406,7 +406,7 @@ public function create_definition($component, $area, $aggregate = null) {
$definition = $instance->get_definition_by_id($id);
if (!$definition) {
throw new coding_exception('The requested cache definition does not exist.'. $id, $id);
- } else {
+ } else if (!$this->is_disabled()) {
debugging('Cache definitions reparsed causing cache reset in order to locate definition.
You should bump the version number to ensure definitions are reprocessed.', DEBUG_DEVELOPER);
}
@@ -442,6 +442,7 @@ protected function create_dummy_store(cache_definition $definition) {
* @return cache_lock_interface
*/
public function create_lock_instance(array $config) {
+ global $CFG;
if (!array_key_exists('name', $config) || !array_key_exists('type', $config)) {
throw new coding_exception('Invalid cache lock instance provided');
}
@@ -450,8 +451,16 @@ public function create_lock_instance(array $config) {
unset($config['name']);
unset($config['type']);
- if ($this->lockplugins === null) {
- $this->lockplugins = get_plugin_list_with_class('cachelock', '', 'lib.php');
+ if (!isset($this->lockplugins[$type])) {
+ $pluginname = substr($type, 10);
+ $file = $CFG->dirroot."/cache/locks/{$pluginname}/lib.php";
+ if (file_exists($file) && is_readable($file)) {
+ require_once($file);
+ }
+ if (!class_exists($type)) {
+ throw new coding_exception('Invalid lock plugin requested.');
+ }
+ $this->lockplugins[$type] = $type;
}
if (!array_key_exists($type, $this->lockplugins)) {
throw new coding_exception('Invalid cache lock type.');

0 comments on commit 7b9cb73

Please sign in to comment.
Something went wrong with that request. Please try again.