Permalink
Browse files

MDL-39317 assign: Fix for submitted filter on grading table.

Some old upgraded assignments have no timecreated column so use
a different one to check for a valid submission.
  • Loading branch information...
1 parent 847f1dd commit 7bf288a64067f2e90f5afa9d31e235356ebed7e0 @damyon damyon committed May 29, 2013
Showing with 7 additions and 5 deletions.
  1. +7 −5 mod/assign/gradingtable.php
@@ -139,15 +139,17 @@ public function __construct(assign $assignment, $perpage, $filter, $rowoffset, $
// The filters do not make sense when there are no submissions, so do not apply them.
if ($this->assignment->is_any_submission_plugin_enabled()) {
if ($filter == ASSIGN_FILTER_SUBMITTED) {
- $where .= ' AND s.timecreated > 0 ';
- }
- if ($filter == ASSIGN_FILTER_REQUIRE_GRADING) {
+ $where .= ' AND (s.timemodified IS NOT NULL AND
+ s.status = :submitted) ';
+ $params['submitted'] = ASSIGN_SUBMISSION_STATUS_SUBMITTED;
+
+ } else if ($filter == ASSIGN_FILTER_REQUIRE_GRADING) {
$where .= ' AND (s.timemodified IS NOT NULL AND
s.status = :submitted AND
(s.timemodified > g.timemodified OR g.timemodified IS NULL))';
$params['submitted'] = ASSIGN_SUBMISSION_STATUS_SUBMITTED;
- }
- if (strpos($filter, ASSIGN_FILTER_SINGLE_USER) === 0) {
+
+ } else if (strpos($filter, ASSIGN_FILTER_SINGLE_USER) === 0) {
$userfilter = (int) array_pop(explode('=', $filter));
$where .= ' AND (u.id = :userid)';
$params['userid'] = $userfilter;

0 comments on commit 7bf288a

Please sign in to comment.