Permalink
Browse files

ALL LANGUAGE EDITORS PLEASE NOTICE THIS CHECKIN

I've changed htmlentities to htmlspecialchars in this file, to fix
bugs with editing multibyte languages (ie Japanese).  Please be
cautious and let me know if this causes any problems when editing
your language (it shouldn't, but I don't want to spoil your day!)
  • Loading branch information...
1 parent 7089640 commit 7f1717c61e41147fc4ed5a4025315d71a1e982e7 moodler committed Nov 22, 2002
Showing with 3 additions and 3 deletions.
  1. +3 −3 admin/lang.php
View
@@ -87,7 +87,7 @@
$first = true;
foreach ($enstring as $key => $value) {
if (!isset($string[$key])) {
- $value = htmlentities($value);
+ $value = htmlspecialchars($value);
$value = str_replace("$"."a", "\\$"."a", $value);
if ($first) {
echo "</PRE><HR><P><B>".get_string("stringsnotset","","$langdir/$file")."</B></P><PRE>";
@@ -179,7 +179,7 @@
}
echo "<TABLE WIDTH=\"100%\" CELLPADDING=2 CELLSPACING=3 BORDER=0>";
foreach ($enstring as $key => $envalue) {
- $envalue = nl2br(htmlentities($envalue));
+ $envalue = nl2br(htmlspecialchars($envalue));
$envalue = str_replace("\$a","<B>\$a</B>", $envalue); // Make variables bold
// TODO: It would be nice if all the $a->something variables were bold too
@@ -188,7 +188,7 @@
echo "<TD WIDTH=40% BGCOLOR=\"$THEME->cellheading\" VALIGN=TOP>$envalue</TD>";
$value = str_replace("\\","",$string[$key]); // Delete all slashes
- $value = htmlentities($value);
+ $value = htmlspecialchars($value);
if ($editable) {
echo "<TD WIDTH=40% VALIGN=TOP>";
if (isset($string[$key])) {

0 comments on commit 7f1717c

Please sign in to comment.