Permalink
Browse files

MDL-33755 SCORM: fix the way launch is triggered

fixes bug with the way it handles skipview set to first time.
  • Loading branch information...
1 parent 410b7c9 commit 812bdaeb12134c774645c2898531afe9a98a5bb6 @danmarsden danmarsden committed Sep 12, 2012
Showing with 3 additions and 5 deletions.
  1. +2 −4 mod/scorm/view.js
  2. +1 −1 mod/scorm/view.php
View
@@ -24,10 +24,8 @@ M.mod_scormform.init = function(Y) {
poptions = poptions+',width='+cwidth+',height='+cheight;
}
- if (launch != false) {
- if (launch == 2) {
- launch_url = launch_url+"&display=popup";
- }
+ if (launch == true) {
+ launch_url = launch_url+"&display=popup";
window.open(launch_url,'Popup', poptions);
parent.window.location = course_url;
}
View
@@ -80,7 +80,7 @@
}
$scoid = $sco->id;
}
- $launch = $scorm->skipview;
+ $launch = true;
}
}
$PAGE->requires->data_for_js('scormplayerdata', Array('launch' => $launch,

0 comments on commit 812bdae

Please sign in to comment.