Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-30652 SCORM Fixing report prefrences display issue for basic report

  • Loading branch information...
commit 8755b6aaca327f7cadb5a78f43372821544b3163 1 parent bea916a
@ankitagarwal ankitagarwal authored
Showing with 6 additions and 5 deletions.
  1. +6 −5 mod/scorm/report/basic/report.php
View
11 mod/scorm/report/basic/report.php
@@ -519,17 +519,18 @@ function display($scorm, $cm, $course, $download) {
echo '</tr></table>';
}
}
- if (!$download) {
- $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
- $mform->display();
- }
} else {
if ($candelete && !$download) {
echo '</div>';
echo '</form>';
+ $table->finish_output();
}
echo '</div>';
- echo $OUTPUT->notification(get_string('noactivity', 'scorm'));
+ }
+ // Show preferences form irrespective of attempts are there to report or not
+ if (!$download) {
+ $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
+ $mform->display();
}
if ($download == 'Excel' or $download == 'ODS') {
$workbook->close();
Please sign in to comment.
Something went wrong with that request. Please try again.