Permalink
Browse files

MDL-29080 grade: simplified bug fix to prevent users without the requ…

…ired capabilities from being able to export hidden grade items
  • Loading branch information...
1 parent baa5cd8 commit 8887fd9a77f6285abe2305249be8d2d6a08042f6 @andyjdavis andyjdavis committed Feb 8, 2012
Showing with 8 additions and 1 deletion.
  1. +8 −1 grade/export/grade_export_form.php
View
9 grade/export/grade_export_form.php
@@ -115,7 +115,14 @@ function definition() {
if ($grade_items = $gseq->items) {
$needs_multiselect = false;
+ $canviewhidden = has_capability('moodle/grade:viewhidden', get_context_instance(CONTEXT_COURSE, $COURSE->id));
+
foreach ($grade_items as $grade_item) {
+ // Is the grade_item hidden? If so, can the user see hidden grade_items?
+ if ($grade_item->is_hidden() && !$canviewhidden) {
+ continue;
+ }
+
if (!empty($features['idnumberrequired']) and empty($grade_item->idnumber)) {
$mform->addElement('advcheckbox', 'itemids['.$grade_item->id.']', $grade_item->get_name(), get_string('noidnumber', 'grades'));
$mform->hardFreeze('itemids['.$grade_item->id.']');
@@ -124,7 +131,7 @@ function definition() {
$mform->setDefault('itemids['.$grade_item->id.']', 1);
$needs_multiselect = true;
}
- }
+ }
if ($needs_multiselect) {
$this->add_checkbox_controller(1, null, null, 1); // 1st argument is group name, 2nd is link text, 3rd is attributes and 4th is original value

0 comments on commit 8887fd9

Please sign in to comment.