Permalink
Browse files

MDL-34774 Lesson module: fixed report stats for 'high score' and 'low…

… score' values where there is only one attempt with 0 score
  • Loading branch information...
1 parent f29e62c commit 8b8d7fcd17302c1d4663f85f1b1fab8a4949a954 @rwijaya rwijaya committed Feb 28, 2013
Showing with 12 additions and 5 deletions.
  1. +12 −5 mod/lesson/report.php
View
17 mod/lesson/report.php
@@ -286,10 +286,10 @@
$numofattempts++;
$avescore += $try["grade"];
$avetime += $timetotake;
- if ($try["grade"] > $highscore || $highscore == NULL) {
+ if ($try["grade"] > $highscore || $highscore === NULL) {
$highscore = $try["grade"];
}
- if ($try["grade"] < $lowscore || $lowscore == NULL) {
+ if ($try["grade"] < $lowscore || $lowscore === NULL) {
$lowscore = $try["grade"];
}
if ($timetotake > $hightime || $hightime == NULL) {
@@ -348,10 +348,10 @@
} else {
$lowtime = format_time($lowtime);
}
- if ($highscore == NULL) {
+ if ($highscore === NULL) {
$highscore = get_string("notcompleted", "lesson");
}
- if ($lowscore == NULL) {
+ if ($lowscore === NULL) {
$lowscore = get_string("notcompleted", "lesson");
}
@@ -364,7 +364,14 @@
$stattable->align = array('center', 'center', 'center', 'center', 'center', 'center');
$stattable->wrap = array('nowrap', 'nowrap', 'nowrap', 'nowrap', 'nowrap', 'nowrap');
$stattable->attributes['class'] = 'standardtable generaltable';
- $stattable->data[] = array($avescore.'%', $avetime, $highscore.'%', $lowscore.'%', $hightime, $lowtime);
+
+ if (is_numeric($highscore)) {
+ $highscore .= '%';
+ }
+ if (is_numeric($lowscore)) {
+ $lowscore .= '%';
+ }
+ $stattable->data[] = array($avescore.'%', $avetime, $highscore, $lowscore, $hightime, $lowtime);
echo html_writer::table($stattable);
} else if ($action === 'reportdetail') {

0 comments on commit 8b8d7fc

Please sign in to comment.