Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

MDL-37919 Let PHPUnit display the content of $a even if the error str…

…ing is not found
  • Loading branch information...
commit 8d37c9b2d9836e99112dbcf6a39f7899184b1e5d 1 parent 1918a24
@mudrd8mz mudrd8mz authored
Showing with 9 additions and 0 deletions.
  1. +9 −0 lib/setuplib.php
View
9 lib/setuplib.php
@@ -137,14 +137,23 @@ function __construct($errorcode, $module='', $link='', $a=NULL, $debuginfo=null)
if (get_string_manager()->string_exists($errorcode, $module)) {
$message = get_string($errorcode, $module, $a);
+ $haserrorstring = true;
} else {
$message = $module . '/' . $errorcode;
+ $haserrorstring = false;
}
if (defined('PHPUNIT_TEST') and PHPUNIT_TEST and $debuginfo) {
$message = "$message ($debuginfo)";
}
+ if (!$haserrorstring and defined('PHPUNIT_TEST') and PHPUNIT_TEST) {
+ // Append the contents of $a to $debuginfo so helpful information isn't lost.
+ // This emulates what {@link get_exception_info()} does. Unfortunately that
+ // function is not used by phpunit.
+ $message .= PHP_EOL.'$a contents: '.print_r($a, true);
+ }
+
parent::__construct($message, 0);
}
}
Please sign in to comment.
Something went wrong with that request. Please try again.