Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-29462 html_to_text('0') gives '', not '0'.

Conflicts:

	lib/simpletest/testweblib.php
  • Loading branch information...
commit 8dce32bb7b6f91ecb94b6dd59b49b7da057b837c 1 parent 51e1e3d
Tim Hunt timhunt authored
2  lib/html2text.php
View
@@ -333,7 +333,7 @@ class html2text
*/
function html2text( $source = '', $from_file = false, $do_links = true, $width = 75 )
{
- if ( !empty($source) ) {
+ if ($source !== '') {
$this->set_html($source, $from_file);
}
15 lib/html2text_readme.txt
View
@@ -53,3 +53,18 @@ Index: lib/html2text.php
}
-- Tim Hunt 2010-11-02
+
+4 - Make sure html2text does not destroy '0'.
+
+index e2d0dff..9cc213d 100644
+--- a/lib/html2text.php
++++ b/lib/html2text.php
+@@ -335,7 +335,7 @@ class html2text
+ */
+ function html2text( $source = '', $from_file = false, $do_links = true, $wi {
+- if ( !empty($source) ) {
++ if ($source !== '') {
+ $this->set_html($source, $from_file);
+ }
+
+-- Tim Hunt 2011-09-21
8 lib/simpletest/testweblib.php
View
@@ -136,6 +136,14 @@ public function test_html_to_text_dont_screw_up_utf8() {
$this->assertEqual("\n\nAll the WORLD’S a stage.", html_to_text('<p>All the <strong>world’s</strong> a stage.</p>'));
}
+ public function test_html_to_text_trailing_whitespace() {
+ $this->assertEqual('With trailing whitespace and some more text', html_to_text("With trailing whitespace \nand some more text", 0));
+ }
+
+ public function test_html_to_text_0() {
+ $this->assertIdentical('0', html_to_text('0'));
+ }
+
public function test_clean_text() {
$text = "lala <applet>xx</applet>";
$this->assertEqual($text, clean_text($text, FORMAT_PLAIN));
Please sign in to comment.
Something went wrong with that request. Please try again.