diff --git a/lib/templates/dynamic_tabs.mustache b/lib/templates/dynamic_tabs.mustache index 34d49e9ebe2fe..0c1cdb8a744ce 100644 --- a/lib/templates/dynamic_tabs.mustache +++ b/lib/templates/dynamic_tabs.mustache @@ -48,7 +48,7 @@ {{#showtabsnavigation}} @@ -92,4 +96,4 @@ {{/hasactivefilters}} {{/filters}} - \ No newline at end of file + diff --git a/reportbuilder/templates/local/settings/sorting.mustache b/reportbuilder/templates/local/settings/sorting.mustache index 1a0feef1ffa54..75c20e7061710 100644 --- a/reportbuilder/templates/local/settings/sorting.mustache +++ b/reportbuilder/templates/local/settings/sorting.mustache @@ -54,7 +54,11 @@ {{>core/drag_handle}} {{#sorticon}} - @@ -76,4 +80,4 @@ {{/ core_reportbuilder/local/settings/empty_message }} {{/hassortablecolumns}} {{/sorting}} - \ No newline at end of file + diff --git a/reportbuilder/templates/local/sidebar-menu/card.mustache b/reportbuilder/templates/local/sidebar-menu/card.mustache index 76764cf3e8ab8..ee34a5fcd8e9e 100644 --- a/reportbuilder/templates/local/sidebar-menu/card.mustache +++ b/reportbuilder/templates/local/sidebar-menu/card.mustache @@ -41,4 +41,4 @@ {{/body}} {{/ core_reportbuilder/toggle_card }} - \ No newline at end of file + diff --git a/reportbuilder/templates/table_header_cell.mustache b/reportbuilder/templates/table_header_cell.mustache index dacdfb4d57a06..c0055beca0f89 100644 --- a/reportbuilder/templates/table_header_cell.mustache +++ b/reportbuilder/templates/table_header_cell.mustache @@ -35,12 +35,16 @@
{{entityname}} • {{name}} - - {{#pix}}e/cancel, core, {{#str}}deletecolumn, core_reportbuilder, {{{name}}}{{/str}}{{/pix}} - +
-
{{{headingeditable}}}
+

{{{headingeditable}}}

{{{aggregationeditable}}} diff --git a/reportbuilder/templates/toggle_card.mustache b/reportbuilder/templates/toggle_card.mustache index ec6a54d1dc7f3..36620127c233d 100644 --- a/reportbuilder/templates/toggle_card.mustache +++ b/reportbuilder/templates/toggle_card.mustache @@ -29,16 +29,16 @@ } }}
-
+
{{$header}}{{/header}} {{$helpicon}}{{/helpicon}}
-
+
{{$body}}{{/body}}
-
\ No newline at end of file +
diff --git a/reportbuilder/tests/behat/cardview.feature b/reportbuilder/tests/behat/cardview.feature index d2edf23d24a8b..190cabced1002 100644 --- a/reportbuilder/tests/behat/cardview.feature +++ b/reportbuilder/tests/behat/cardview.feature @@ -39,7 +39,7 @@ Feature: Manage card view settings in the report editor And the following fields match these values: | Columns visible | 3 | | First column title | Yes | - And I click on "Delete column 'Full name'" "link" + And I click on "Delete column 'Full name'" "button" And I click on "Delete" "button" in the "Delete column 'Full name'" "dialogue" # Check that 'Columns visible' select updates taking into account report maximum columns. And the field "visiblecolumns" matches value "2" diff --git a/reportbuilder/tests/behat/columneditor.feature b/reportbuilder/tests/behat/columneditor.feature index f95816f62d6bb..1b9576934acd5 100644 --- a/reportbuilder/tests/behat/columneditor.feature +++ b/reportbuilder/tests/behat/columneditor.feature @@ -63,7 +63,7 @@ Feature: Manage custom report columns | report | uniqueidentifier | | My report | user:fullname | And I am on the "My report" "reportbuilder > Editor" page logged in as "admin" - When I click on "Delete column 'Full name'" "link" + When I click on "Delete column 'Full name'" "button" And I click on "Delete" "button" in the "Delete column 'Full name'" "dialogue" Then I should see "Deleted column 'Full name'" And I should see "Nothing to display" diff --git a/reportbuilder/tests/behat/columnsortingeditor.feature b/reportbuilder/tests/behat/columnsortingeditor.feature index 95cf40fe319ba..41421aa9795b7 100644 --- a/reportbuilder/tests/behat/columnsortingeditor.feature +++ b/reportbuilder/tests/behat/columnsortingeditor.feature @@ -67,6 +67,6 @@ Feature: Manage custom report columns sorting Given I click on "Show/hide settings sidebar" "button" And I change window size to "large" And I click on "Show/hide 'Sorting'" "button" - When I click on "Delete column 'Username'" "link" + When I click on "Delete column 'Username'" "button" And I click on "Delete" "button" in the "Delete column 'Username'" "dialogue" Then I should not see "Username" in the "#settingssorting" "css_element" diff --git a/reportbuilder/tests/behat/conditioneditor.feature b/reportbuilder/tests/behat/conditioneditor.feature index b1517ac16cca8..4c408198ec5a2 100644 --- a/reportbuilder/tests/behat/conditioneditor.feature +++ b/reportbuilder/tests/behat/conditioneditor.feature @@ -60,7 +60,7 @@ Feature: Manage custom report conditions | Email address operator | Does not contain | | Email address value | user02 | And I click on "Apply" "button" in the "[data-region='settings-conditions']" "css_element" - And I click on "Delete condition 'Email address'" "link" + And I click on "Delete condition 'Email address'" "button" And I click on "Delete" "button" in the "Delete condition 'Email address'" "dialogue" Then I should see "Deleted condition 'Email address'" And I should see "There are no conditions selected" in the "[data-region='settings-conditions']" "css_element" diff --git a/reportbuilder/tests/behat/filtereditor.feature b/reportbuilder/tests/behat/filtereditor.feature index ff0f0243d14af..e97a60f5f4469 100644 --- a/reportbuilder/tests/behat/filtereditor.feature +++ b/reportbuilder/tests/behat/filtereditor.feature @@ -79,7 +79,7 @@ Feature: Manage custom report filters And I am on the "My report" "reportbuilder > Editor" page logged in as "admin" When I click on "Show/hide settings sidebar" "button" And I click on "Show/hide 'Filters'" "button" - And I click on "Delete filter 'Email address'" "link" + And I click on "Delete filter 'Email address'" "button" And I click on "Delete" "button" in the "Delete filter 'Email address'" "dialogue" Then I should see "Deleted filter 'Email address'" And I should see "There are no filters selected" in the "[data-region='active-filters']" "css_element" diff --git a/theme/boost/scss/moodle/reportbuilder.scss b/theme/boost/scss/moodle/reportbuilder.scss index 4183abcb51e80..757b4f1f952c4 100644 --- a/theme/boost/scss/moodle/reportbuilder.scss +++ b/theme/boost/scss/moodle/reportbuilder.scss @@ -92,7 +92,7 @@ /* Custom table headers */ .reportbuilder-table th { - a[data-action="report-remove-column"], + button[data-action="report-remove-column"], span[data-drag-type="move"] { .icon { width: 12px; @@ -102,7 +102,7 @@ color: $body-color; } } - a[data-action="report-remove-column"] .icon { + button[data-action="report-remove-column"] .icon { margin-right: 0; } } @@ -142,8 +142,8 @@ font-size: 12px; color: $body-color; } - a[data-action="report-remove-filter"], - a[data-action="report-remove-condition"] { + button[data-action="report-remove-filter"], + button[data-action="report-remove-condition"] { .icon { margin-right: 0; vertical-align: text-top; diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css index 8bb73c9b9c166..c8fe4f52eedfd 100644 --- a/theme/boost/style/moodle.css +++ b/theme/boost/style/moodle.css @@ -20715,7 +20715,7 @@ div.editor_atto_toolbar button .icon { min-width: 0; } /* Custom table headers */ -.reportbuilder-table th a[data-action="report-remove-column"] .icon, +.reportbuilder-table th button[data-action="report-remove-column"] .icon, .reportbuilder-table th span[data-drag-type="move"] .icon { width: 12px; height: 12px; @@ -20723,7 +20723,7 @@ div.editor_atto_toolbar button .icon { vertical-align: text-top; color: #1d2125; } -.reportbuilder-table th a[data-action="report-remove-column"] .icon { +.reportbuilder-table th button[data-action="report-remove-column"] .icon { margin-right: 0; } /* Sidebar menu */ @@ -20765,8 +20765,8 @@ div.editor_atto_toolbar button .icon { height: 12px; font-size: 12px; color: #1d2125; } - .reportbuilder-sidebar-settings .list-group-item a[data-action="report-remove-filter"] .icon, - .reportbuilder-sidebar-settings .list-group-item a[data-action="report-remove-condition"] .icon { + .reportbuilder-sidebar-settings .list-group-item button[data-action="report-remove-filter"] .icon, + .reportbuilder-sidebar-settings .list-group-item button[data-action="report-remove-condition"] .icon { margin-right: 0; vertical-align: text-top; } .reportbuilder-sidebar-settings .list-group-item span[data-drag-type="move"] .icon { diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css index 0a8a55c0037e1..c7ec56d18d6e7 100644 --- a/theme/classic/style/moodle.css +++ b/theme/classic/style/moodle.css @@ -20661,7 +20661,7 @@ div.editor_atto_toolbar button .icon { min-width: 0; } /* Custom table headers */ -.reportbuilder-table th a[data-action="report-remove-column"] .icon, +.reportbuilder-table th button[data-action="report-remove-column"] .icon, .reportbuilder-table th span[data-drag-type="move"] .icon { width: 12px; height: 12px; @@ -20669,7 +20669,7 @@ div.editor_atto_toolbar button .icon { vertical-align: text-top; color: #1d2125; } -.reportbuilder-table th a[data-action="report-remove-column"] .icon { +.reportbuilder-table th button[data-action="report-remove-column"] .icon { margin-right: 0; } /* Sidebar menu */ @@ -20711,8 +20711,8 @@ div.editor_atto_toolbar button .icon { height: 12px; font-size: 12px; color: #1d2125; } - .reportbuilder-sidebar-settings .list-group-item a[data-action="report-remove-filter"] .icon, - .reportbuilder-sidebar-settings .list-group-item a[data-action="report-remove-condition"] .icon { + .reportbuilder-sidebar-settings .list-group-item button[data-action="report-remove-filter"] .icon, + .reportbuilder-sidebar-settings .list-group-item button[data-action="report-remove-condition"] .icon { margin-right: 0; vertical-align: text-top; } .reportbuilder-sidebar-settings .list-group-item span[data-drag-type="move"] .icon {