Skip to content
Permalink
Browse files

MDL-55012 Atto: no style attrs on paste

Specifically on paste - we don't need all the random style attributes
from content on the clipboard. When you copy from a webpage - the browser
inlines all the styles from the page so that the pasted content will look
like the place it was copied from. But this is never what you want - you
want the content on paste, but with no special styling.
  • Loading branch information...
damyon committed Jun 26, 2016
1 parent b8474fe commit 91445c63f8ce1de3aea7b8e5bdcb5129e0d507d1
@@ -1522,14 +1522,6 @@ EditorClean.prototype = {

// Run some more rules that care about quotes and whitespace.
rules = [
// Get all style attributes so we can work on them.
{regex: /(<[^>]*?style\s*?=\s*?")([^>"]*)(")/gi, replace: function(match, group1, group2, group3) {
// Remove MSO-blah, MSO:blah style attributes.
group2 = group2.replace(/(?:^|;)[\s]*MSO[-:](?:&[\w]*;|[^;"])*/gi,"");
// Remove backgroud color style.
group2 = group2.replace(/background-color:.*?;/gi,"");
return group1 + group2 + group3;
}},
// Get all class attributes so we can work on them.
{regex: /(<[^>]*?class\s*?=\s*?")([^>"]*)(")/gi, replace: function(match, group1, group2, group3) {
// Remove MSO classes.
@@ -1542,6 +1534,9 @@ EditorClean.prototype = {
{regex: /<a [^>]*?name\s*?=\s*?"OLE_LINK\d*?"[^>]*?>\s*?<\/a>/gi, replace: ""}
];

// Clean all style attributes from the text.
content = this._cleanStyles(content);

// Apply the rules.
content = this._filterContentWithRules(content, rules);

@@ -1554,6 +1549,33 @@ EditorClean.prototype = {
return content;
},

/**
* Clean all inline styles from pasted text.
*
* This code intentionally doesn't use YUI Nodes. YUI was quite a bit slower at this, so using raw DOM objects instead.
*
* @method _cleanStyles
* @private
* @param {String} content The content to clean
* @return {String} The cleaned HTML
*/
_cleanStyles: function(content) {
var holder = document.createElement('div');
holder.innerHTML = content;
var elementsWithStyle = holder.querySelectorAll('[style]');
var i = 0;

for (i = 0; i < elementsWithStyle.length; i++) {
elementsWithStyle[i].removeAttribute('style');
}

var elementsWithClass = holder.querySelectorAll('[class]');
for (i = 0; i < elementsWithClass.length; i++) {
elementsWithClass[i].removeAttribute('class');
}

return holder.innerHTML;
},
/**
* Clean empty or un-unused spans from passed HTML.
*

0 comments on commit 91445c6

Please sign in to comment.
You can’t perform that action at this time.